Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1456793003: Re-use callback objects in the DataUseAggregator. (Closed)

Created:
5 years, 1 month ago by sclittle
Modified:
5 years, 1 month ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-use callback objects in the DataUseAggregator. This CL makes the DataUseAggregator re-use the same callback objects separately for annotation and amortization calls, as an optimization to avoid allocating and holding on to a new callback object for every call. This CL should have no noticible effects other than using less memory. BUG= Committed: https://crrev.com/2955091ca0b685a7a08a335df14f70c7eceeb0bc Cr-Commit-Position: refs/heads/master@{#360437}

Patch Set 1 #

Patch Set 2 : Rebased on master #

Patch Set 3 : Fixed WeakPtr threading issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M components/data_usage/core/data_use_aggregator.h View 3 chunks +8 lines, -2 lines 0 comments Download
M components/data_usage/core/data_use_aggregator.cc View 1 2 4 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sclittle
5 years, 1 month ago (2015-11-18 00:14:42 UTC) #2
tbansal1
lgtm
5 years, 1 month ago (2015-11-18 00:54:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456793003/1
5 years, 1 month ago (2015-11-18 01:11:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142194) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 01:51:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456793003/20001
5 years, 1 month ago (2015-11-18 02:30:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142256)
5 years, 1 month ago (2015-11-18 02:50:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456793003/40001
5 years, 1 month ago (2015-11-18 21:55:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-18 23:09:16 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:10:10 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2955091ca0b685a7a08a335df14f70c7eceeb0bc
Cr-Commit-Position: refs/heads/master@{#360437}

Powered by Google App Engine
This is Rietveld 408576698