Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1456783005: Fix nearly-vertical gradient assert (Closed)

Created:
5 years, 1 month ago by f(malita)
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix nearly-vertical gradient assert Use a SkScalarNearlyZero(dx) test instead of !SkScalarIsFinite(invDx). R=reed@google.com Committed: https://skia.googlesource.com/skia/+/8d381022e72f49c2ad02c6fc3fbbb6f03c95bdf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GradientTest.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
f(malita)
Passes unit test + problematic Blink layout test.
5 years, 1 month ago (2015-11-19 17:59:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456783005/1
5 years, 1 month ago (2015-11-19 17:59:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 18:13:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456783005/1
5 years, 1 month ago (2015-11-19 18:15:41 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-19 18:15:42 UTC) #8
reed1
lgtm
5 years, 1 month ago (2015-11-19 18:33:02 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 18:35:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d381022e72f49c2ad02c6fc3fbbb6f03c95bdf2

Powered by Google App Engine
This is Rietveld 408576698