Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1456783004: Remove configuration policy on iOS. (Closed)

Created:
5 years, 1 month ago by bzanotti
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove configuration policy on iOS. BUG=550407 Committed: https://crrev.com/7a82b0d4950154a3cd5b0dcdf2c906b5cc763658 Cr-Commit-Position: refs/heads/master@{#360559}

Patch Set 1 #

Patch Set 2 : Clean up gyp and DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -154 lines) Patch
M ios/chrome/browser/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/application_context.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ios/chrome/browser/application_context_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 3 chunks +2 lines, -27 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.h View 3 chunks +1 line, -15 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 3 chunks +0 lines, -15 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.h View 3 chunks +2 lines, -9 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc View 4 chunks +2 lines, -14 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/test/testing_application_context.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/test/testing_application_context.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bzanotti
Please take a look.
5 years, 1 month ago (2015-11-18 18:34:38 UTC) #2
sdefresne
On 2015/11/18 at 18:34:38, bzanotti wrote: > Please take a look. drive-by: you probably also ...
5 years, 1 month ago (2015-11-18 18:39:46 UTC) #3
droger
sdefresne: good point. bzanotti, can you look into this? Other than that, LGTM
5 years, 1 month ago (2015-11-19 09:05:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456783004/1
5 years, 1 month ago (2015-11-19 10:15:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456783004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456783004/20001
5 years, 1 month ago (2015-11-19 10:36:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 11:00:22 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 11:01:32 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7a82b0d4950154a3cd5b0dcdf2c906b5cc763658
Cr-Commit-Position: refs/heads/master@{#360559}

Powered by Google App Engine
This is Rietveld 408576698