Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1456773002: skip new generic method test if task model is not on (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jennifer Messerly
Oops, I had two CL's out at the same time, the second one added this ...
5 years, 1 month ago (2015-11-17 23:04:46 UTC) #2
Jennifer Messerly
edit: fixed CL description.
5 years, 1 month ago (2015-11-17 23:05:26 UTC) #4
Brian Wilkerson
Phil might not be able to review this quickly, but LGTM.
5 years, 1 month ago (2015-11-17 23:16:51 UTC) #6
Jennifer Messerly
On 2015/11/17 23:16:51, Brian Wilkerson wrote: > Phil might not be able to review this ...
5 years, 1 month ago (2015-11-17 23:22:26 UTC) #7
Jennifer Messerly
Committed patchset #1 (id:1) manually as ec994696df529267ea4d27a55365271a873ef8ce (presubmit successful).
5 years, 1 month ago (2015-11-17 23:22:52 UTC) #8
pquitslund
5 years, 1 month ago (2015-11-18 02:15:37 UTC) #9
Message was sent while issue was closed.
On 2015/11/17 23:22:52, John Messerly wrote:
> Committed patchset #1 (id:1) manually as
> ec994696df529267ea4d27a55365271a873ef8ce (presubmit successful).

LGTM!

(Better late than never :))

Powered by Google App Engine
This is Rietveld 408576698