Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: third_party/WebKit/public/web/WebWidgetClient.h

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebWidgetClient.h
diff --git a/third_party/WebKit/public/web/WebWidgetClient.h b/third_party/WebKit/public/web/WebWidgetClient.h
index 41fe6692ea5aac06cdf84e4e3614cece960bdede..1eeff1bd3844f09c520c16ab8411fec90fbb5283 100644
--- a/third_party/WebKit/public/web/WebWidgetClient.h
+++ b/third_party/WebKit/public/web/WebWidgetClient.h
@@ -175,6 +175,15 @@ public:
// press or gesture tap.
// Note: This is called even when the mouse down event is prevent default.
virtual void onMouseDown(const WebNode& mouseDownNode) { }
+
+ // Converts the |rect| from Blink's Viewport coordinates to the
+ // coordinates in the native window used to display the content, in
+ // DIP. They're identical in tradional world, but will differ when
+ // use-zoom-for-dsf feature is eanbled, and Viewport coordinates
+ // becomes DSF times larger than window coordinates.
+ // TODO(oshima): Update this comment when all platforms are migrated.
+ virtual void convertViewportToWindow(WebRect* rect) {}
+
protected:
~WebWidgetClient() { }
};

Powered by Google App Engine
This is Rietveld 408576698