third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index 5488a951af657152cd3f6241aaf0d61bd38b3f31..c0198e443398bfaeb4aef155df05565eca427916 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -512,13 +512,14 @@ void ChromeClientImpl::scheduleAnimationForFrame(LocalFrame* localRoot)

IntRect ChromeClientImpl::viewportToScreen(const IntRect& rectInViewport) const

{

- IntRect screenRect(rectInViewport);

+ WebRect screenRect(rectInViewport);

if (m_webView->client()) {

+ m_webView->client()->convertViewportToWindow(&screenRect);

WebRect windowRect = m_webView->client()->windowRect();

- screenRect.move(windowRect.x, windowRect.y);

+ screenRect.x += windowRect.x;

+ screenRect.y += windowRect.y;

}

return screenRect;

}