Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/webview_plugin.cc
diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc
index 5e185c19f74a27039f78b1967f7e8b6c18e0cf7e..8f7024bcb11a4bac7be237b52691a8ea3d8e16a8 100644
--- a/components/plugins/renderer/webview_plugin.cc
+++ b/components/plugins/renderer/webview_plugin.cc
@@ -264,6 +264,11 @@ void WebViewPlugin::startDragging(WebLocalFrame*,
web_view_->dragSourceSystemDragEnded();
}
+void WebViewPlugin::convertViewportToWindow(blink::WebRect* rect) {
+ // TODO(oshima): Figure out what to do.
+ NOTIMPLEMENTED();
+}
+
bool WebViewPlugin::allowsBrokenNullLayerTreeView() const {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698