Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 11feeba5ef4e97ca0e7fd7b1e99496e421315f5c..353049e7fa5e0620ef5c19e5c83556a2ce35707e 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -511,12 +511,10 @@ void ChromeClientImpl::scheduleAnimationForFrame(LocalFrame* localRoot)
IntRect ChromeClientImpl::viewportToScreen(const IntRect& rectInViewport) const
tkent 2015/11/18 07:06:39 We can't change the behavior of this function. Th
oshima 2015/11/18 13:03:24 Yes, this is to keep the same behavior in zoom-for
{
- IntRect screenRect(rectInViewport);
+ WebRect screenRect(rectInViewport);
- if (m_webView->client()) {
- WebRect windowRect = m_webView->client()->windowRect();
- screenRect.move(windowRect.x, windowRect.y);
- }
+ if (m_webView->client())
+ m_webView->client()->convertViewportToScreen(&screenRect);
return screenRect;
}

Powered by Google App Engine
This is Rietveld 408576698