content/renderer/render_view_impl.h - Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | content/renderer/render_view_impl.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index c2527cdc353e42496a8d4378990ee9a934b52c2b..0df0bad1d25037d25b106f6650b22e883721324b 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -476,7 +476,6 @@ class CONTENT_EXPORT RenderViewImpl

void OnImeConfirmComposition(const base::string16& text,

const gfx::Range& replacement_range,

bool keep_selection) override;

- void SetDeviceScaleFactor(float device_scale_factor) override;

bool SetDeviceColorProfile(const std::vector<char>& color_profile) override;

void OnOrientationChange() override;

ui::TextInputType GetTextInputType() override;

@@ -491,6 +490,7 @@ class CONTENT_EXPORT RenderViewImpl

#if defined(OS_ANDROID)

bool DoesRecordFullLayer() const override;

#endif

+ void OnDeviceScaleFactorChanged() override;

protected:

RenderViewImpl(CompositorDependencies* compositor_deps,

@@ -765,7 +765,7 @@ class CONTENT_EXPORT RenderViewImpl

void UpdateThemePrefs() {}

#endif

- void UpdateDeviceScaleFactor();

+ void UpdateWebViewWithDeviceScaleFactor();

// ---------------------------------------------------------------------------

// ADDING NEW FUNCTIONS? Please keep private functions alphabetized and put