components/plugins/renderer/webview_plugin.h - Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.h

Issue 1456753002: Compute the popup location/size correctly when use-zoom-for-dsf is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/plugins/renderer/webview_plugin.h

diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h

index cfc991eed6d51cba7ac8d45fcefd8f466f8abbbb..d51e9ae21712ab3ee866b2837c827985b3ab4cb6 100644

--- a/components/plugins/renderer/webview_plugin.h

+++ b/components/plugins/renderer/webview_plugin.h

@@ -127,6 +127,7 @@ class WebViewPlugin : public blink::WebPlugin,

blink::WebDragOperationsMask mask,

const blink::WebImage& image,

const blink::WebPoint& point) override;

+ void convertViewportToScreen(blink::WebRect* rect) override;

// TODO(ojan): Remove this override and have this class use a non-null

// layerTreeView.

« no previous file with comments | « no previous file | components/plugins/renderer/webview_plugin.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')