Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1456703004: ScopedPtrMap -> std::map from /ui/gfx/image (Closed)

Created:
5 years, 1 month ago by limasdf
Modified:
5 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScopedPtrMap -> std::map from /ui/gfx/image C++ 11 enables containers that contain move-only type, scoped_ptr. So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap. also use std::move() instead of scoped_ptr::Pass(). BUG=554291, 557422 Committed: https://crrev.com/659c25756ef6c83ec07736f03d0d80bdfe32882d Cr-Commit-Position: refs/heads/master@{#360461}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use insert() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/gfx/image/image.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/image/image.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
limasdf
PTAL. I re-created (I was thinking something wrong from previous CL, but actually correct)
5 years, 1 month ago (2015-11-18 22:59:17 UTC) #3
danakj
https://codereview.chromium.org/1456703004/diff/1/ui/gfx/image/image.cc File ui/gfx/image/image.cc (right): https://codereview.chromium.org/1456703004/diff/1/ui/gfx/image/image.cc#newcode752 ui/gfx/image/image.cc:752: storage_->representations()[type] = std::move(rep); why'd you change it to [] ...
5 years, 1 month ago (2015-11-18 23:03:56 UTC) #4
limasdf
https://codereview.chromium.org/1456703004/diff/1/ui/gfx/image/image.cc File ui/gfx/image/image.cc (right): https://codereview.chromium.org/1456703004/diff/1/ui/gfx/image/image.cc#newcode752 ui/gfx/image/image.cc:752: storage_->representations()[type] = std::move(rep); On 2015/11/18 23:03:56, danakj (behind on ...
5 years, 1 month ago (2015-11-18 23:12:08 UTC) #5
danakj
LGTM
5 years, 1 month ago (2015-11-18 23:15:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456703004/20001
5 years, 1 month ago (2015-11-18 23:16:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 01:18:34 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:19:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/659c25756ef6c83ec07736f03d0d80bdfe32882d
Cr-Commit-Position: refs/heads/master@{#360461}

Powered by Google App Engine
This is Rietveld 408576698