Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1456703003: AfterStartupTask: Use ForTesting() method rather than friends. (Closed)

Created:
5 years, 1 month ago by wkorman
Modified:
5 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AfterStartupTask: Use ForTesting() method rather than friends. android::AfterStartupTaskUtilsJNI is an anomaly and is noted for further investigation. BUG=546640 Committed: https://crrev.com/8a21c4fc737f2d3d008a08fffdb674c4b943f931 Cr-Commit-Position: refs/heads/master@{#360380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M chrome/browser/after_startup_task_utils.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/after_startup_task_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/after_startup_task_utils_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
wkorman
Follow-up from http://crrev.com/1452003002
5 years, 1 month ago (2015-11-18 00:12:01 UTC) #3
Devlin
lgtm, thanks :)
5 years, 1 month ago (2015-11-18 00:13:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456703003/1
5 years, 1 month ago (2015-11-18 00:13:44 UTC) #6
Lei Zhang
rs lgtm
5 years, 1 month ago (2015-11-18 00:29:14 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 01:40:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456703003/1
5 years, 1 month ago (2015-11-18 18:59:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 19:06:18 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:07:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a21c4fc737f2d3d008a08fffdb674c4b943f931
Cr-Commit-Position: refs/heads/master@{#360380}

Powered by Google App Engine
This is Rietveld 408576698