Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1456693002: Make ChromeVox Next swallow key events that correspond to commands. (Closed)

Created:
5 years, 1 month ago by dmazzoni
Modified:
5 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeVox Next swallow key events that correspond to commands. Otherwise pressing, e.g., Search+DownArrow still sends a DownArrow to the page. BUG=425598 Committed: https://crrev.com/fa395807fb784712a8b49436afd91076dbbc198b Cr-Commit-Position: refs/heads/master@{#360237}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra line #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 chunks +13 lines, -2 lines 1 comment Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 10 (3 generated)
dmazzoni
5 years, 1 month ago (2015-11-17 20:19:26 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/1456693002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/1456693002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode416 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:416: * nit: extra line
5 years, 1 month ago (2015-11-17 20:42:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456693002/20001
5 years, 1 month ago (2015-11-18 00:08:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 00:41:36 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fa395807fb784712a8b49436afd91076dbbc198b Cr-Commit-Position: refs/heads/master@{#360237}
5 years, 1 month ago (2015-11-18 00:42:54 UTC) #8
dmazzoni
https://codereview.chromium.org/1456693002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/1456693002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode416 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:416: * On 2015/11/17 20:42:00, David Tseng wrote: > nit: ...
5 years, 1 month ago (2015-11-18 16:59:17 UTC) #9
David Tseng
5 years, 1 month ago (2015-11-19 01:11:50 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1456693002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1456693002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:420:
if (!cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {
Sorry missed something here. This needs to be mode aware: classic should never
eat keys and not attempt to process the command at all.

Powered by Google App Engine
This is Rietveld 408576698