Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1456643002: Don't unsubscribe to streams we aren't subscribed to. (Closed)

Created:
5 years, 1 month ago by turnidge
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't unsubscribe to streams we aren't subscribed to. Gets rid of some stray uncaught exceptions when running Flutter. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b9af3683fdd1f6baebec89959c05462dc8944ab2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 1 month ago (2015-11-17 19:12:30 UTC) #2
Cutch
lgtm
5 years, 1 month ago (2015-11-17 19:18:39 UTC) #3
turnidge
5 years, 1 month ago (2015-11-17 19:29:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9af3683fdd1f6baebec89959c05462dc8944ab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698