Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: src/objects.h

Issue 1456613002: [proxies] Update Object.defineProperty/ies for JSProxies (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/v8natives.js ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index cacde85f1fbf4a31e2191ce7d1f6655ad0ac4ee7..30ea750961b7741fccdcf92ca73a063d4604718f 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -9524,6 +9524,11 @@ class JSProxy: public JSReceiver {
static bool GetOwnPropertyDescriptor(LookupIterator* it,
PropertyDescriptor* desc);
+ // ES6 9.5.6
+ static bool DefineOwnProperty(Isolate* isolate, Handle<JSProxy> object,
+ Handle<Object> key, PropertyDescriptor* desc,
+ ShouldThrow should_throw);
+
MUST_USE_RESULT static MaybeHandle<Object> GetPropertyWithHandler(
Handle<JSProxy> proxy,
Handle<Object> receiver,
@@ -9540,9 +9545,8 @@ class JSProxy: public JSReceiver {
Handle<Object> value, ShouldThrow should_throw, bool* done);
MUST_USE_RESULT static Maybe<PropertyAttributes>
- GetPropertyAttributesWithHandler(Handle<JSProxy> proxy,
- Handle<Object> receiver,
- Handle<Name> name);
+ GetPropertyAttributesWithHandler(LookupIterator* it);
+
neis 2015/11/17 21:37:40 Can we get rid of the "WithHandler" suffix?
Jakob Kummerow 2015/11/18 14:35:50 Done.
MUST_USE_RESULT static Maybe<bool> SetPropertyWithHandler(
Handle<JSProxy> proxy, Handle<Object> receiver, Handle<Name> name,
Handle<Object> value, ShouldThrow should_throw);
« no previous file with comments | « src/js/v8natives.js ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698