Issue 14566024: Remove hung renderer dialog black border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14566024: Remove hung renderer dialog black border. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove hung renderer dialog black border. HungRendererDialogView uses Widget::CreateWindow. Use DialogDelegate::CreateDialogWidget instead, add context. Does not change the old-style appearance or behavior. See before/after pics at http://crbug.com/166075#c80 Trigger the dialog with about:hang or debug code in Patch Set 1. BUG=166075 TEST=Hung renderer dialog does not have an extra border. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200572

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/hung_renderer_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/views/hung_renderer_view.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/14566024/1004

7 years, 7 months ago (2013-05-16 16:13:14 UTC) #3

Message was sent while issue was closed.

Change committed as 200572

Expand Messages | Collapse Messages