Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 14566020: - Correctly handle negative constant indices when (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 22702)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -2311,15 +2311,21 @@
Range* index_range = index()->definition()->range();
// Range of the index is unknown can't decide if the check is redundant.
- if (index_range == NULL) return false;
+ if (index_range == NULL) {
+ return false;
+ }
// Range of the index is not positive. Check can't be redundant.
- if (Range::ConstantMin(index_range).value() < 0) return false;
+ if (Range::ConstantMin(index_range).value() < 0) {
+ return false;
+ }
RangeBoundary max = CanonicalizeBoundary(index_range->max(),
RangeBoundary::OverflowedMaxSmi());
- if (max.Overflowed()) return false;
+ if (max.Overflowed()) {
+ return false;
+ }
// Try to compare constant boundaries.
if (max.UpperBound().value() < length.LowerBound().value()) {
@@ -2327,7 +2333,9 @@
}
length = CanonicalizeBoundary(length, RangeBoundary::OverflowedMaxSmi());
- if (length.Overflowed()) return false;
+ if (length.Overflowed()) {
+ return false;
+ }
// Try symbolic comparison.
do {
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698