Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chromeos/network/cert_loader.cc

Issue 14566009: Add NetworkConnectionHandler class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/cert_loader.cc
diff --git a/chromeos/network/cert_loader.cc b/chromeos/network/cert_loader.cc
index 1198accc1cb56595a1b670ec9c04bd391a8998c8..87a0373d7f694425e85ca946de14f755b8799ee7 100644
--- a/chromeos/network/cert_loader.cc
+++ b/chromeos/network/cert_loader.cc
@@ -8,6 +8,7 @@
#include "base/chromeos/chromeos_version.h"
#include "base/observer_list.h"
+#include "base/strings/string_number_conversions.h"
#include "base/task_runner_util.h"
#include "base/threading/worker_pool.h"
#include "chromeos/dbus/cryptohome_client.h"
@@ -119,6 +120,36 @@ void CertLoader::RequestCertificates() {
return;
}
+// For background see this discussion on dev-tech-crypto.lists.mozilla.org:
+// http://web.archiveorange.com/archive/v/6JJW7E40sypfZGtbkzxX
+//
+// NOTE: This function relies on the convention that the same PKCS#11 ID
+// is shared between a certificate and its associated private and public
+// keys. I tried to implement this with PK11_GetLowLevelKeyIDForCert(),
+// but that always returns NULL on Chrome OS for me.
+std::string CertLoader::GetPkcs11IdForCert(
+ const net::X509Certificate& cert) const {
+ if (!IsHardwareBacked())
+ return std::string();
+
+ CERTCertificateStr* cert_handle = cert.os_cert_handle();
+ SECKEYPrivateKey *priv_key =
+ PK11_FindKeyByAnyCert(cert_handle, NULL /* wincx */);
+ if (!priv_key)
+ return std::string();
+
+ // Get the CKA_ID attribute for a key.
+ SECItem* sec_item = PK11_GetLowLevelKeyIDForPrivateKey(priv_key);
+ std::string pkcs11_id;
+ if (sec_item) {
+ pkcs11_id = base::HexEncode(sec_item->data, sec_item->len);
+ SECITEM_FreeItem(sec_item, PR_TRUE);
+ }
+ SECKEY_DestroyPrivateKey(priv_key);
+
+ return pkcs11_id;
+}
+
void CertLoader::OnTpmIsEnabled(DBusMethodCallStatus call_status,
bool tpm_is_enabled) {
VLOG(1) << "OnTpmIsEnabled: " << tpm_is_enabled;

Powered by Google App Engine
This is Rietveld 408576698