Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: chromeos/dbus/shill_manager_client.h

Issue 14566009: Add NetworkConnectionHandler class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback, remove configuration. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_manager_client.h
diff --git a/chromeos/dbus/shill_manager_client.h b/chromeos/dbus/shill_manager_client.h
index f1b4d8c9d4f3e6a55555dbdf001ef5fb8949c9b2..6f6530dcf0f9af05035375aab6d736b78d3a2b3f 100644
--- a/chromeos/dbus/shill_manager_client.h
+++ b/chromeos/dbus/shill_manager_client.h
@@ -42,13 +42,6 @@ class CHROMEOS_EXPORT ShillManagerClient {
virtual void AddDevice(const std::string& device_path) = 0;
virtual void RemoveDevice(const std::string& device_path) = 0;
virtual void ClearDevices() = 0;
- virtual void AddService(const std::string& service_path,
- bool add_to_watch_list) = 0;
- virtual void AddServiceAtIndex(const std::string& service_path,
- size_t index,
- bool add_to_watch_list) = 0;
- virtual void RemoveService(const std::string& service_path) = 0;
- virtual void ClearServices() = 0;
virtual void AddTechnology(const std::string& type, bool enabled) = 0;
virtual void RemoveTechnology(const std::string& type) = 0;
virtual void SetTechnologyInitializing(const std::string& type,
@@ -59,6 +52,18 @@ class CHROMEOS_EXPORT ShillManagerClient {
// Used to reset all properties; does not notify observers.
virtual void ClearProperties() = 0;
+ // Move an existing service to a different index, e.g. to simulate the
+ // result of a successful connect.
+ virtual void MoveServiceToIndex(const std::string& service_path,
+ size_t index,
+ bool add_to_watch_list) = 0;
+
+ // Add/Remove/ClearService should only be called from ShillServiceClient.
+ virtual void AddManagerService(const std::string& service_path,
+ bool add_to_watch_list) = 0;
+ virtual void RemoveManagerService(const std::string& service_path) = 0;
+ virtual void ClearManagerServices() = 0;
+
protected:
virtual ~TestInterface() {}
};

Powered by Google App Engine
This is Rietveld 408576698