Support 'URLSearchParams' as the body of a Request

Support 'URLSearchParams' as the body of a Request

As specified in Fetch, this patch allows 'URLSearchParams' to be passed
into the Request constructor, or into the RequestInit parameter of a
call to 'fetch()'. The object will be serialized as a urlencoded string,
and used as the body of the resulting request.

BUG=303152
NOTRY=true

Committed: https://crrev.com/03eaf889ebe699c3a5af069d4a2ef2206c6431ad
Cr-Commit-Position: refs/heads/master@{#360326}

[Mike West, 2015-11-17 14:08:12]

mkwst@chromium.org changed reviewers:
+ horo@chromium.org, tyoshino@chromium.org

[Mike West, 2015-11-17 14:08:12]

Hello, horo@ and tyoshino@! Would you mind taking a look at this small addition
to Fetch, as part of the URLSearchParams implementation that's landing in
https://codereview.chromium.org/1442643008?

[horo, 2015-11-18 03:40:52]

lgtm with nits

https://codereview.chromium.org/1456553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/URLSearchParamsTest.cpp (right):

https://codereview.chromium.org/1456553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/URLSearchParamsTest.cpp:8: #include
"platform/heap/Handle.h"
remove

https://codereview.chromium.org/1456553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/URLSearchParamsTest.cpp:9: #include
"platform/network/EncodedFormData.h"
remove

https://codereview.chromium.org/1456553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/URLSearchParamsTest.cpp:10: #include
<gmock/gmock.h>
remove

[Mike West, 2015-11-18 08:14:02]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-11-18 08:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/1456553002/#ps20001
(title: "Feedback")

[commit-bot: I haz the power, 2015-11-18 08:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001

[commit-bot: I haz the power, 2015-11-18 09:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 09:53:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2015-11-18 10:28:20]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-11-18 10:28:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001

[commit-bot: I haz the power, 2015-11-18 12:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 12:02:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2015-11-18 13:17:45]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-11-18 13:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001

[Mike West, 2015-11-18 13:31:46]

Description was changed from

==========
Support 'URLSearchParams' as the body of a Request

As specified in Fetch, this patch allows 'URLSearchParams' to be passed
into the Request constructor, or into the RequestInit parameter of a
call to 'fetch()'. The object will be serialized as a urlencoded string,
and used as the body of the resulting request.

BUG=303152
==========

to

==========
Support 'URLSearchParams' as the body of a Request

As specified in Fetch, this patch allows 'URLSearchParams' to be passed
into the Request constructor, or into the RequestInit parameter of a
call to 'fetch()'. The object will be serialized as a urlencoded string,
and used as the body of the resulting request.

BUG=303152
NOTRY=true
==========

[Mike West, 2015-11-18 13:32:11]

On 2015/11/18 at 13:17:50, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001

NOTRYing the patch, as the `linux_chromium_rel_ng` bot is crashing on every
layout test. :/

[Mike West, 2015-11-18 13:32:23]

On 2015/11/18 at 13:32:11, Mike West wrote:
> On 2015/11/18 at 13:17:50, commit-bot wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001
> 
> NOTRYing the patch, as the `linux_chromium_rel_ng` bot is crashing on every
layout test. :/

(For everyone, not just for me. :) )

[Mike West, 2015-11-18 13:32:28]

The CQ bit was unchecked by mkwst@chromium.org

[Mike West, 2015-11-18 13:32:30]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-11-18 13:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456553002/20001

[commit-bot: I haz the power, 2015-11-18 13:38:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-18 13:39:36]

Patchset 2 (id:??) landed as
https://crrev.com/03eaf889ebe699c3a5af069d4a2ef2206c6431ad
Cr-Commit-Position: refs/heads/master@{#360326}

[tyoshino (SeeGerritForStatus), 2015-11-24 13:57:18]

lgtm

Sorry for delay. Made a follow up CL instead of making comments on this closed
issue.
https://codereview.chromium.org/1473243002/