Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 1456543003: Fix gcc 4.9.2 signed-compare error. (Closed)

Created:
5 years, 1 month ago by akos.palfi.imgtec
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gcc 4.9.2 signed-compare error. BUG= Committed: https://crrev.com/0403fd860cb5846562f604ed3503cdde7964b4cb Cr-Commit-Position: refs/heads/master@{#32053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
akos.palfi.imgtec
PTAL.
5 years, 1 month ago (2015-11-17 15:37:30 UTC) #2
Jakob Kummerow
LGTM, but: (1) you should send these to whoever introduced the offending lines -> CC ...
5 years, 1 month ago (2015-11-17 15:44:16 UTC) #4
akos.palfi.imgtec
On 2015/11/17 15:44:16, Jakob wrote: > LGTM, but: > > (1) you should send these ...
5 years, 1 month ago (2015-11-17 15:49:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456543003/1
5 years, 1 month ago (2015-11-17 15:49:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 16:07:05 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 16:07:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0403fd860cb5846562f604ed3503cdde7964b4cb
Cr-Commit-Position: refs/heads/master@{#32053}

Powered by Google App Engine
This is Rietveld 408576698