Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1456523002: Revert of Remove redundant activation threshold for incremental marking. (Closed)

Created:
5 years, 1 month ago by ulan
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove redundant activation threshold for incremental marking. (patchset #1 id:1 of https://codereview.chromium.org/1418293006/ ) Reason for revert: Regression in thread_times.key_idle_power_cases (crbug.com/555153) Original issue's description: > Remove redundant activation threshold for incremental marking. > > The minimum allocation limit already enforces this constraint for normal GCs. > > GCs triggered by the memory reducer and external limit should work for all heap sizes. > > BUG=chromium:552305 > LOG=NO > > Committed: https://crrev.com/e28e4d5f52852e2f14facc37a02069b6bfc82c4e > Cr-Commit-Position: refs/heads/master@{#31921} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:552305 Committed: https://crrev.com/401efe2173b1d777634996817bf85fe3bde434f0 Cr-Commit-Position: refs/heads/master@{#32038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/heap/incremental-marking.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Created Revert of Remove redundant activation threshold for incremental marking.
5 years, 1 month ago (2015-11-17 13:12:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456523002/1
5 years, 1 month ago (2015-11-17 13:12:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 13:13:07 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 13:13:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/401efe2173b1d777634996817bf85fe3bde434f0
Cr-Commit-Position: refs/heads/master@{#32038}

Powered by Google App Engine
This is Rietveld 408576698