Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 145643008: base: Add uncached malloc based discardable memory type. (Closed)

Created:
6 years, 11 months ago by reveman
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

base: Add uncached malloc based discardable memory type. Each DiscardableMemoryMalloc instance uses a separate malloc() allocated block of memory. It's allocated on Lock() and freed on Unlock(). This is useful to test how discardable memory clients perform in situations when the memory pressure is high. The base class will also be used by other discardable memory implementations as a fall-back when failing to allocate/lock native discardable memory. BUG=334996 TEST=base_unittests --gtest_filter=DiscardableMemoryTests* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -22 lines) Patch
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/discardable_memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/memory/discardable_memory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/memory/discardable_memory_android.cc View 3 chunks +11 lines, -1 line 0 comments Download
M base/memory/discardable_memory_linux.cc View 3 chunks +11 lines, -1 line 0 comments Download
M base/memory/discardable_memory_mac.cc View 3 chunks +11 lines, -1 line 0 comments Download
A + base/memory/discardable_memory_malloc.h View 2 chunks +8 lines, -13 lines 0 comments Download
A base/memory/discardable_memory_malloc.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Philippe
lgtm, thanks!
6 years, 10 months ago (2014-02-06 11:47:23 UTC) #1
reveman
Ok, let's land this so we can use it both for testing and as a ...
6 years, 10 months ago (2014-02-10 05:32:21 UTC) #2
willchan no longer on Chromium
LGTM I updated your changelist description to include more implementations details, obviously feel free to ...
6 years, 10 months ago (2014-02-10 06:44:22 UTC) #3
reveman
On 2014/02/10 06:44:22, willchan wrote: > LGTM > > I updated your changelist description to ...
6 years, 10 months ago (2014-02-10 17:07:04 UTC) #4
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 10 months ago (2014-02-10 17:07:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/145643008/1
6 years, 10 months ago (2014-02-10 17:07:55 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 19:19:32 UTC) #7
Message was sent while issue was closed.
Change committed as 250167

Powered by Google App Engine
This is Rietveld 408576698