Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145643006: Linux: enable SxS (side-by-side) support (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Linux: enable SxS (side-by-side) support This also adjusts the logic for .desktop file finding. BUG=38598 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254788

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/shell_integration_linux.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M chrome/common/chrome_version_info_posix.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/installer/linux/debian/build.sh View 1 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-23 20:23:01 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/145643006/diff/1/chrome/browser/shell_integration_linux.cc File chrome/browser/shell_integration_linux.cc (right): https://codereview.chromium.org/145643006/diff/1/chrome/browser/shell_integration_linux.cc#newcode41 chrome/browser/shell_integration_linux.cc:41: #include "chrome/common/chrome_version_info.h" already #included 2 lines below. https://codereview.chromium.org/145643006/diff/1/chrome/installer/linux/debian/build.sh ...
6 years, 11 months ago (2014-01-23 21:31:30 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/145643006/diff/1/chrome/browser/shell_integration_linux.cc File chrome/browser/shell_integration_linux.cc (right): https://codereview.chromium.org/145643006/diff/1/chrome/browser/shell_integration_linux.cc#newcode41 chrome/browser/shell_integration_linux.cc:41: #include "chrome/common/chrome_version_info.h" On 2014/01/23 21:31:30, Lei Zhang wrote: > ...
6 years, 10 months ago (2014-01-29 19:03:23 UTC) #3
Paweł Hajdan Jr.
6 years, 9 months ago (2014-03-04 18:43:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r254788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698