Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1456423003: [runtime] Introduce a proper %NewArray runtime entry. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Introduce a proper %NewArray runtime entry. This adds a new %NewArray runtime entry, which constructs a new JSArray and does the subclassing correctly (to the same degree that %NewObject does currently), and also deals properly with the AllocationSite feedback mechanism. This runtime entry will be used by TurboFan and is also used as a fallback in the subclassing case in the stub currently. BUG=v8:3101, v8:3330 LOG=n Committed: https://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5 Cr-Commit-Position: refs/heads/master@{#32131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -154 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +20 lines, -20 lines 0 comments Download
M src/runtime/runtime-array.cc View 4 chunks +64 lines, -68 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Yang, Some cleanup for the Array constructor. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-20 06:03:05 UTC) #2
Yang
On 2015/11/20 06:03:05, Benedikt Meurer wrote: > Hey Yang, > > Some cleanup for the ...
5 years, 1 month ago (2015-11-20 06:17:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456423003/1
5 years, 1 month ago (2015-11-20 06:20:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 06:21:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 06:21:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceade6cf239e0773213d53d55c36b19231c820b5
Cr-Commit-Position: refs/heads/master@{#32131}

Powered by Google App Engine
This is Rietveld 408576698