Make PersonalDataManager use GetCreditCards() (rather than using credit_cards_ directly) so Autofill

chrome/browser/autofill/autofill_browsertest.cc

Index: chrome/browser/autofill/autofill_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc
index 92686574026395224f0b3af4e3cbc87936d638ea..927dfbe4871c97be5c48899087c96ced74e7eb16 100644
--- a/chrome/browser/autofill/autofill_browsertest.cc
+++ b/chrome/browser/autofill/autofill_browsertest.cc
@@ -1136,9 +1136,9 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, FillProfileCrazyCharacters) {
   cards.push_back(card4);
 
   SetCards(&cards);
-  ASSERT_EQ(cards.size(), personal_data_manager()->credit_cards().size());
+  ASSERT_EQ(cards.size(), personal_data_manager()->GetCreditCards().size());
   for (size_t i = 0; i < cards.size(); ++i)
-    ASSERT_EQ(cards[i], *personal_data_manager()->credit_cards()[i]);
+    ASSERT_EQ(cards[i], *personal_data_manager()->GetCreditCards()[i]);

[Lei Zhang, 2013/05/01 04:08:52]

nits you may want to fix later - maybe just call GetCreditCard() once rather
than over and over again in the loop?

[Lei Zhang, 2013/05/01 04:08:52]

you may also want to just EXPECT_EQ here. Ditto with some of the tests below
once you know you are not going to go out of bounds.

[Dan Beam, 2013/05/01 04:19:36]

while I agree it should be EXPECT_EQ() here I really don't want to change this
in this CL

[Dan Beam, 2013/05/01 04:19:36]

yeah, I'm not sure of the point of that... though it's probably quite cheap.  I
think just the name being GetCreditCards() makes it scarier than credit_cards()
because of chrome's dumb_accessor() vs MayDoALot() naming...

 }
 
 // Test filling in invalid values for profiles are saved as-is. Phone
@@ -1173,8 +1173,8 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, PrefsStringSavedAsIs) {
   card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("Not_0123-5Checked"));
   SetCard(card);
 
-  ASSERT_EQ(1u, personal_data_manager()->credit_cards().size());
-  ASSERT_EQ(card, *personal_data_manager()->credit_cards()[0]);
+  ASSERT_EQ(1u, personal_data_manager()->GetCreditCards().size());
+  ASSERT_EQ(card, *personal_data_manager()->GetCreditCards()[0]);
 }
 
 // Test credit card info with an invalid number is not aggregated.
@@ -1201,11 +1201,11 @@ IN_PROC_BROWSER_TEST_F(AutofillTest,
   SubmitCreditCard("Bob Smith", "4408 0412 3456 7893", "12", "2014");
   SubmitCreditCard("Jane Doe", "4417-1234-5678-9113", "10", "2013");
 
-  ASSERT_EQ(2u, personal_data_manager()->credit_cards().size());
-  string16 cc1 = personal_data_manager()->credit_cards()[0]->GetRawInfo(
+  ASSERT_EQ(2u, personal_data_manager()->GetCreditCards().size());
+  string16 cc1 = personal_data_manager()->GetCreditCards()[0]->GetRawInfo(
       CREDIT_CARD_NUMBER);
   ASSERT_TRUE(autofill::IsValidCreditCardNumber(cc1));
-  string16 cc2 = personal_data_manager()->credit_cards()[1]->GetRawInfo(
+  string16 cc2 = personal_data_manager()->GetCreditCards()[1]->GetRawInfo(
       CREDIT_CARD_NUMBER);
   ASSERT_TRUE(autofill::IsValidCreditCardNumber(cc2));
 }