Make PersonalDataManager use GetCreditCards() (rather than using credit_cards_ directly) so Autofill

chrome/browser/ui/webui/options/autofill_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/autofill_options_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 373 matching lines @@
        i != personal_data_->web_profiles().end(); ++i) {
     ListValue* entry = new ListValue();
     entry->Append(new StringValue((*i)->guid()));
     entry->Append(new StringValue((*i)->Label()));
     addresses.Append(entry);
   }
 
   web_ui()->CallJavascriptFunction("AutofillOptions.setAddressList", addresses);
 
   ListValue credit_cards;
-  for (std::vector<CreditCard*>::const_iterator i =
-           personal_data_->credit_cards().begin();
-       i != personal_data_->credit_cards().end(); ++i) {
-    const CreditCard* card = *i;
+  const std::vector<CreditCard*>& cards = personal_data_->GetCreditCards();
+  for (std::vector<CreditCard*>::const_iterator iter = cards.begin();
+       iter != cards.end(); ++iter) {
+    const CreditCard* card = *iter;
     // TODO(estade): this should be a dictionary.
     ListValue* entry = new ListValue();
     entry->Append(new StringValue(card->guid()));
     entry->Append(new StringValue(card->Label()));
     entry->Append(new StringValue(
         webui::GetBitmapDataUrlFromResource(card->IconResourceId())));
     entry->Append(new StringValue(card->TypeForDisplay()));
     credit_cards.Append(entry);
   }
 
@@ skipping 189 matching lines @@
 
   web_ui()->CallJavascriptFunction(
     "AutofillEditAddressOverlay.setValidatedPhoneNumbers", *list_value);
 }
 
 bool AutofillOptionsHandler::IsPersonalDataLoaded() const {
   return personal_data_ && personal_data_->IsDataLoaded();
 }
 
 }  // namespace options