Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 14564003: Make PersonalDataManager use GetCreditCards() (rather than using credit_cards_ directly) so Autofill (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autofill/android/personal_data_manager_android.h" 5 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/stringprintf.h" 9 #include "base/stringprintf.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 profile.set_guid(guid); 202 profile.set_guid(guid);
203 personal_data_manager_->UpdateProfile(profile); 203 personal_data_manager_->UpdateProfile(profile);
204 } 204 }
205 205
206 return ConvertUTF8ToJavaString(env, profile.guid()); 206 return ConvertUTF8ToJavaString(env, profile.guid());
207 } 207 }
208 208
209 209
210 jint PersonalDataManagerAndroid::GetCreditCardCount(JNIEnv* unused_env, 210 jint PersonalDataManagerAndroid::GetCreditCardCount(JNIEnv* unused_env,
211 jobject unused_obj) { 211 jobject unused_obj) {
212 return personal_data_manager_->credit_cards().size(); 212 return personal_data_manager_->GetCreditCards().size();
213 } 213 }
214 214
215 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByIndex( 215 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByIndex(
216 JNIEnv* env, 216 JNIEnv* env,
217 jobject unused_obj, 217 jobject unused_obj,
218 jint index) { 218 jint index) {
219 const std::vector<CreditCard*>& credit_cards = 219 const std::vector<CreditCard*>& credit_cards =
220 personal_data_manager_->credit_cards(); 220 personal_data_manager_->GetCreditCards();
221 size_t index_size_t = static_cast<size_t>(index); 221 size_t index_size_t = static_cast<size_t>(index);
222 DCHECK_LT(index_size_t, credit_cards.size()); 222 DCHECK_LT(index_size_t, credit_cards.size());
223 return CreateJavaCreditCardFromNative(env, *credit_cards[index_size_t]); 223 return CreateJavaCreditCardFromNative(env, *credit_cards[index_size_t]);
224 } 224 }
225 225
226 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByGUID( 226 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByGUID(
227 JNIEnv* env, 227 JNIEnv* env,
228 jobject unused_obj, 228 jobject unused_obj,
229 jstring jguid) { 229 jstring jguid) {
230 CreditCard* card = personal_data_manager_->GetCreditCardByGUID( 230 CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 return RegisterNativesImpl(env); 275 return RegisterNativesImpl(env);
276 } 276 }
277 277
278 static jint Init(JNIEnv* env, jobject obj) { 278 static jint Init(JNIEnv* env, jobject obj) {
279 PersonalDataManagerAndroid* personal_data_manager_android = 279 PersonalDataManagerAndroid* personal_data_manager_android =
280 new PersonalDataManagerAndroid(env, obj); 280 new PersonalDataManagerAndroid(env, obj);
281 return reinterpret_cast<jint>(personal_data_manager_android); 281 return reinterpret_cast<jint>(personal_data_manager_android);
282 } 282 }
283 283
284 } // namespace autofill 284 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | chrome/browser/autofill/autofill_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698