Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1456383002: Fix maybe unintialized warning for GrAutoLocaleSetter (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix maybe unintialized warning for GrAutoLocaleSetter In function void test_GLPrograms(skiatest::Reporter*, GrContextFactory*): ../../../src/gpu/GrAutoLocaleSetter.h:47:35: error: als.GrAutoLocaleSetter::fOldLocale may be used uninitialized in this function [-Werror=maybe-uninitialized] From Build-Ubuntu-GCC-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/4222e19aeaf72ccfb61f83f4fe41010750161c74

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrAutoLocaleSetter.h View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/4336/steps/build%20most/logs/stdio
5 years, 1 month ago (2015-11-19 09:56:43 UTC) #1
Kimmo Kinnunen
For some reason, the AutoLocaleSetter starts to fail compile with the patch: https://codereview.chromium.org/1446453003/ Here's the ...
5 years, 1 month ago (2015-11-19 10:15:18 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-11-19 14:44:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456383002/20001
5 years, 1 month ago (2015-11-19 16:33:44 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:45:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4222e19aeaf72ccfb61f83f4fe41010750161c74

Powered by Google App Engine
This is Rietveld 408576698