Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1456333002: Make layout tests in editing/inserting to use w3c test harness (Closed)

Created:
5 years, 1 month ago by yosin_UTC9
Modified:
5 years, 1 month ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make layout tests in editing/inserting to use w3c test harness This patch makes following tests to use w3c test harness to simplify tests and avoid to compare pixel results. Pixel results aren't essential for tests changed in this patch and when we enable asynchronous spell checking, pixel result contains red wave lines for miss spelled. These read wave lines aren't related what we want to test. This patch is a preparation of getting rid of synchronous code path for spellcheck to enable asynchronous spell checking always. BUG=295722 TEST=n/a; no behavior changes Committed: https://crrev.com/a96dc167e22087547442ddb659211d8dc85f5af4 Cr-Commit-Position: refs/heads/master@{#360548}

Patch Set 1 : 2015-11-19T14:56:35 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -906 lines) Patch
M third_party/WebKit/LayoutTests/editing/inserting/insert-div-026.html View 2 chunks +21 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-04.html View 1 chunk +17 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/return-key-with-selection-001.html View 1 chunk +21 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/return-key-with-selection-002.html View 2 chunks +21 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-026-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-026-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-04-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-04-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-001-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-002-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-026-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-026-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-04-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-04-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-001-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-002-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/insert-div-026-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/insert-div-026-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/insert-paragraph-04-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/insert-paragraph-04-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/return-key-with-selection-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/return-key-with-selection-001-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/return-key-with-selection-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/inserting/return-key-with-selection-002-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-026-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-026-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-04-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-04-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-001-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-002-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
5 years, 1 month ago (2015-11-19 07:28:19 UTC) #3
hajimehoshi
lgtm
5 years, 1 month ago (2015-11-19 07:30:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456333002/1
5 years, 1 month ago (2015-11-19 07:32:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:37:09 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:38:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a96dc167e22087547442ddb659211d8dc85f5af4
Cr-Commit-Position: refs/heads/master@{#360548}

Powered by Google App Engine
This is Rietveld 408576698