Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1456283007:
get provision_devices to not fall over on user builds (Closed)
|
Created:
5 years ago by bpastene Modified:
5 years ago Reviewers:
jbudorick CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionget provision_devices to not fall over on user builds
BUG=558033
Committed: https://crrev.com/79b8679e7541f1b52d5b7012e6677b8f625f785f
Cr-Commit-Position: refs/heads/master@{#364363}
Patch Set 1 #
Total comments: 4
Patch Set 2 : #
Total comments: 4
Patch Set 3 : #
Messages
Total messages: 22 (7 generated)
Description was changed from ========== get provision_devices to not fall over on user builds BUG= ========== to ========== get provision_devices to not fall over on user builds BUG=558033 ==========
bpastene@chromium.org changed reviewers: + jbudorick@chromium.org
ptal
https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... File build/android/provision_devices.py (right): https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... build/android/provision_devices.py:107: if device.IsUserBuild(): This shouldn't preempt the chrome-specific wipe, which we should be able to do in user builds. https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... build/android/provision_devices.py:366: if not device.IsUserBuild() and not timeout_retry.WaitFor( nit: since this is going to be changed when you figure out how to set the date & time on user builds, I'd prefer this be if device.IsUserBuild(): # TODO(bpastene): ... pass else: if not timeout_retry.WaitFor(_set_and_verify_date, ...): raise device_errors.CommandFailedError(...) which I think is more readable.
https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... File build/android/provision_devices.py (right): https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... build/android/provision_devices.py:107: if device.IsUserBuild(): On 2015/11/21 02:37:13, jbudorick wrote: > This shouldn't preempt the chrome-specific wipe, which we should be able to do > in user builds. Not entirely. I moved what I could into an if_user_build check in WipeChromeData https://codereview.chromium.org/1456283007/diff/1/build/android/provision_dev... build/android/provision_devices.py:366: if not device.IsUserBuild() and not timeout_retry.WaitFor( On 2015/11/21 02:37:13, jbudorick wrote: > nit: since this is going to be changed when you figure out how to set the date & > time on user builds, I'd prefer this be > > if device.IsUserBuild(): > # TODO(bpastene): ... > pass > else: > if not timeout_retry.WaitFor(_set_and_verify_date, ...): > raise device_errors.CommandFailedError(...) > > which I think is more readable. Done.
pring pring I think that poor user-build bot is super red cause it can't provision
oops, slipped off my radar. https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... File build/android/provision_devices.py (right): https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... build/android/provision_devices.py:110: if device.IsUserBuild(): We should just do the chrome-specific wipe on user builds. https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... build/android/provision_devices.py:193: _WipeFileOrDir(device, '/data/local/tmp/') should be able to remove the contents of /data/local/tmp/ on user builds
https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... File build/android/provision_devices.py (right): https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... build/android/provision_devices.py:110: if device.IsUserBuild(): On 2015/12/09 18:09:01, jbudorick wrote: > We should just do the chrome-specific wipe on user builds. Was planning on setting non_device_wipe_provisioning in the config, but that's probably saner https://codereview.chromium.org/1456283007/diff/20001/build/android/provision... build/android/provision_devices.py:193: _WipeFileOrDir(device, '/data/local/tmp/') On 2015/12/09 18:09:01, jbudorick wrote: > should be able to remove the contents of /data/local/tmp/ on user builds Good catch
Looks like this guy is also having the same problem: (I love the bot name btw) https://build.chromium.org/p/chromium.android/builders/Lollipop%20Consumer%20...
On 2015/12/09 22:35:27, bpastene wrote: > Looks like this guy is also having the same problem: (I love the bot name btw) > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Consumer%20... yeah, martiniss brought this up in the group chat.
lgtm
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456283007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456283007/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456283007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456283007/40001
On 2015/12/10 04:14:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...) This ran during the ~ hour when there was a very, very borked recipe.
Message was sent while issue was closed.
Description was changed from ========== get provision_devices to not fall over on user builds BUG=558033 ========== to ========== get provision_devices to not fall over on user builds BUG=558033 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== get provision_devices to not fall over on user builds BUG=558033 ========== to ========== get provision_devices to not fall over on user builds BUG=558033 Committed: https://crrev.com/79b8679e7541f1b52d5b7012e6677b8f625f785f Cr-Commit-Position: refs/heads/master@{#364363} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/79b8679e7541f1b52d5b7012e6677b8f625f785f Cr-Commit-Position: refs/heads/master@{#364363} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
