components/autofill/core/common/password_form_fill_data.cc - Issue 1456263005: Revert of Use std::tie() for operator< in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 1456263005: Revert of Use std::tie() for operator< in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/form_field_data.cc ('k') | components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form_fill_data.cc

diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc

index 1c35ba2bd83318cada9c2f72e050740c8592703a..148b5c2609d838cf467c853cfc2bd44a22a0ab76 100644

--- a/components/autofill/core/common/password_form_fill_data.cc

+++ b/components/autofill/core/common/password_form_fill_data.cc

@@ -3,8 +3,6 @@

// found in the LICENSE file.

#include "components/autofill/core/common/password_form_fill_data.h"

-#include <tuple>

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/common/form_field_data.h"

@@ -17,8 +15,11 @@

bool UsernamesCollectionKey::operator<(

const UsernamesCollectionKey& other) const {

- return std::tie(username, password, realm) <

- std::tie(other.username, other.password, other.realm);

+ if (username != other.username)

+ return username < other.username;

+ if (password != other.password)

+ return password < other.password;

+ return realm < other.realm;

}

PasswordFormFillData::PasswordFormFillData()