Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1456233002: Converts remaining windowmanager property based functions to SetProperty (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts remaining windowmanager property based functions to SetProperty R=ben@chromium.org BUG=none TEST=none Committed: https://crrev.com/4d39af826ffde2d6f1f83d7496f0ad8ec4e03e31 Cr-Commit-Position: refs/heads/master@{#360471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -166 lines) Patch
M components/mus/public/cpp/lib/window.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
M components/mus/ws/forwarding_window_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/ws/forwarding_window_manager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 chunk +4 lines, -28 lines 0 comments Download
M mash/wm/window_manager_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M mash/wm/window_manager_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 1 month ago (2015-11-18 23:32:32 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-19 00:04:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456233002/1
5 years, 1 month ago (2015-11-19 00:24:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:49:48 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:50:57 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d39af826ffde2d6f1f83d7496f0ad8ec4e03e31
Cr-Commit-Position: refs/heads/master@{#360471}

Powered by Google App Engine
This is Rietveld 408576698