Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/typedarray.js

Issue 145623009: Check the offset argument of TypedArray.set for fitting into Smi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-340125.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 for (i = leftIndex; i <= rightIndex; i++) { 236 for (i = leftIndex; i <= rightIndex; i++) {
237 target[offset + i] = temp[i - leftIndex]; 237 target[offset + i] = temp[i - leftIndex];
238 } 238 }
239 } 239 }
240 240
241 function TypedArraySet(obj, offset) { 241 function TypedArraySet(obj, offset) {
242 var intOffset = IS_UNDEFINED(offset) ? 0 : TO_INTEGER(offset); 242 var intOffset = IS_UNDEFINED(offset) ? 0 : TO_INTEGER(offset);
243 if (intOffset < 0) { 243 if (intOffset < 0) {
244 throw MakeTypeError("typed_array_set_negative_offset"); 244 throw MakeTypeError("typed_array_set_negative_offset");
245 } 245 }
246
247 if (intOffset > %MaxSmi()) {
248 throw MakeRangeError("typed_array_set_source_too_large");
249 }
246 switch (%TypedArraySetFastCases(this, obj, intOffset)) { 250 switch (%TypedArraySetFastCases(this, obj, intOffset)) {
247 // These numbers should be synchronized with runtime.cc. 251 // These numbers should be synchronized with runtime.cc.
248 case 0: // TYPED_ARRAY_SET_TYPED_ARRAY_SAME_TYPE 252 case 0: // TYPED_ARRAY_SET_TYPED_ARRAY_SAME_TYPE
249 return; 253 return;
250 case 1: // TYPED_ARRAY_SET_TYPED_ARRAY_OVERLAPPING 254 case 1: // TYPED_ARRAY_SET_TYPED_ARRAY_OVERLAPPING
251 TypedArraySetFromOverlappingTypedArray(this, obj, intOffset); 255 TypedArraySetFromOverlappingTypedArray(this, obj, intOffset);
252 return; 256 return;
253 case 2: // TYPED_ARRAY_SET_TYPED_ARRAY_NONOVERLAPPING 257 case 2: // TYPED_ARRAY_SET_TYPED_ARRAY_NONOVERLAPPING
254 TypedArraySetFromArrayLike(this, obj, obj.length, intOffset); 258 TypedArraySetFromArrayLike(this, obj, obj.length, intOffset);
255 return; 259 return;
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 440
437 "getFloat32", DataViewGetFloat32, 441 "getFloat32", DataViewGetFloat32,
438 "setFloat32", DataViewSetFloat32, 442 "setFloat32", DataViewSetFloat32,
439 443
440 "getFloat64", DataViewGetFloat64, 444 "getFloat64", DataViewGetFloat64,
441 "setFloat64", DataViewSetFloat64 445 "setFloat64", DataViewSetFloat64
442 )); 446 ));
443 } 447 }
444 448
445 SetupDataView(); 449 SetupDataView();
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-340125.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698