Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 145623009: Check the offset argument of TypedArray.set for fitting into Smi. (Closed)

Created:
6 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Check the offset argument of TypedArray.set for fitting into Smi. R=jkummerow@chromium.org BUG=340125 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=19051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/typedarray.js View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-340125.js View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
6 years, 10 months ago (2014-02-04 09:36:17 UTC) #1
Jakob Kummerow
lgtm
6 years, 10 months ago (2014-02-04 09:51:23 UTC) #2
Dmitry Lomov (no reviews)
6 years, 10 months ago (2014-02-04 09:53:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19051 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698