Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1456203002: Swallow the illegal state exception when calling to printmanager (Closed)

Created:
5 years, 1 month ago by sgurun-gerrit only
Modified:
5 years, 1 month ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Swallow the illegal state exception when calling to printmanager We call to printmanager the failure if webview is destroyed and a print job is in progress. However it is possible that binder is already finalized. In this case simply swallow the exception. BUG= Committed: https://crrev.com/1274b729b9bfead6b8b100f72f46df652fe23484 Cr-Commit-Position: refs/heads/master@{#360475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sgurun-gerrit only
On 2015/11/18 23:01:01, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:michaelbai@chromium.org ptal, thanks
5 years, 1 month ago (2015-11-18 23:01:10 UTC) #3
michaelbai
lgtm
5 years, 1 month ago (2015-11-18 23:29:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456203002/1
5 years, 1 month ago (2015-11-19 00:01:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:52:23 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:53:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1274b729b9bfead6b8b100f72f46df652fe23484
Cr-Commit-Position: refs/heads/master@{#360475}

Powered by Google App Engine
This is Rietveld 408576698