Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 14562006: Handle Esc key press event in Local NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/local_ntp/local_ntp.js ('k') | chrome/browser/ui/search/instant_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index 734223f576163de72022b539f28ce94622af602d..d491709007c337e4078718d4db12dad8e01d138a 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -358,14 +358,8 @@ bool InstantController::Update(const AutocompleteMatch& match,
// tab), by comparing the old and new WebContents.
if (escape_pressed &&
instant_tab_->contents() == browser_->GetActiveWebContents()) {
- // If the omnibox is blank, send an onchange("") instead of an
- // onsubmit(""). This is to avoid confusion with the onsubmit("")
- // that we send when the user hits Enter to navigate to a URL.
- // onchange("") is used for a similar situation with the overlay
- // (when the overlay is dismissed because the user hit Escape); it
- // does the right thing for committed tabs as well.
if (full_text.empty())
samarth 2013/05/04 16:37:35 Add a TODO here for sending an escape key press in
kmadhusu 2013/05/05 22:44:54 Done.
- instant_tab_->Update(string16(), 0, 0, true);
+ instant_tab_->EscKeyPressed();
else
instant_tab_->Submit(full_text);
}
« no previous file with comments | « chrome/browser/resources/local_ntp/local_ntp.js ('k') | chrome/browser/ui/search/instant_page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698