Handle Esc key press event in Local NTP.

chrome/browser/ui/search/instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/instant_controller.h"
 
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 361 matching lines @@
           // The user is on a search results page. It may be showing results for
           // a partial query the user typed before they hit Escape. Send the
           // omnibox text to the page to restore the original results.
           //
           // In a tab switch, |instant_tab_| won't have updated yet, so it may
           // be pointing to the previous tab (which was a search results page).
           // Ensure we don't send the omnibox text to a random webpage (the new
           // tab), by comparing the old and new WebContents.
           if (escape_pressed &&
               instant_tab_->contents() == browser_->GetActiveWebContents()) {
-            // If the omnibox is blank, send an onchange("") instead of an
-            // onsubmit(""). This is to avoid confusion with the onsubmit("")
-            // that we send when the user hits Enter to navigate to a URL.
-            // onchange("") is used for a similar situation with the overlay
-            // (when the overlay is dismissed because the user hit Escape); it
-            // does the right thing for committed tabs as well.
-            if (full_text.empty())
+            // TODO(kmadhusu): If the |full_text| is not empty, send an
+            // onkeypress(esc) to the Instant page. Do not call
+            // onsubmit(full_text). Fix.
+            if (full_text.empty()) {
               instant_tab_->Update(string16(), 0, 0, true);

[samarth, 2013/05/06 19:13:37]

Please add a comment for this call: because that we want to clear the query for
the page at this point.

[kmadhusu, 2013/05/06 20:24:44]

Done.

-            else
+              instant_tab_->EscKeyPressed();
+             } else {
               instant_tab_->Submit(full_text);
+            }
           }
         } else if (!full_text.empty()) {
           // If |full_text| is empty, the user is on the NTP. The overlay may
           // be showing custom NTP content; hide only if that's not the case.
           HideOverlay();
         }
       } else if (full_text.empty()) {
         // The user is typing, and backspaced away all omnibox text. Clear
         // |last_omnibox_text_| so that we don't attempt to set suggestions.
         last_omnibox_text_.clear();
@@ skipping 1301 matching lines @@
 }
 
 bool InstantController::UsingLocalPage() const {
   return (UseTabForSuggestions() && instant_tab_->IsLocal()) ||
       (!UseTabForSuggestions() && overlay_ && overlay_->IsLocal());
 }
 
 bool InstantController::UseTabForSuggestions() const {
   return instant_tab_ && use_tab_for_suggestions_;
 }