Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1456183002: Add more assertion to render_text_harfbuzz. (Closed)

Created:
5 years, 1 month ago by Jun Mukai
Modified:
5 years, 1 month ago
Reviewers:
msw, oshima
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more assertion to render_text_harfbuzz. Crashes are reported, but single CHECK_NE isn't helpful because the variable actually comes from either of two -- script_item_break and style. Things will become clearer by adding a CHECK for script_item_break. BUG=403892 R=oshima@chromium.org, msw@chromium.org Committed: https://crrev.com/13db1406f0aa142c8b2e777d080b76bc08d49896 Cr-Commit-Position: refs/heads/master@{#360473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/gfx/render_text_harfbuzz.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jun Mukai
5 years, 1 month ago (2015-11-18 22:40:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456183002/1
5 years, 1 month ago (2015-11-18 22:42:47 UTC) #3
msw
lgtm
5 years, 1 month ago (2015-11-18 23:23:48 UTC) #4
oshima
lgtm
5 years, 1 month ago (2015-11-18 23:25:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 00:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456183002/1
5 years, 1 month ago (2015-11-19 00:38:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:51:05 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:52:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13db1406f0aa142c8b2e777d080b76bc08d49896
Cr-Commit-Position: refs/heads/master@{#360473}

Powered by Google App Engine
This is Rietveld 408576698