Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1456123002: Remove Remaining Predictor Jank Instrumentation (Closed)

Created:
5 years, 1 month ago by robliao
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Remaining Predictor Jank Instrumentation This instrumentation is no longer providing any value for the jank dashboard. BUG=436671 Committed: https://crrev.com/e0476ccefa17a0849652b7e0b9af878e8d297b82 Cr-Commit-Position: refs/heads/master@{#360595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -43 lines) Patch
M chrome/browser/net/predictor.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +10 lines, -16 lines 0 comments Download
M components/domain_reliability/config.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/domain_reliability/monitor.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
robliao
Hello! Please review these mechanical instrumentation removal changes. Thanks! rtenneti: chrome/browser/net/predictor.cc skuhne: chrome/browser/profiles/profile_impl_io_data.cc ttuttle: components/domain_reliability/config.cc ...
5 years, 1 month ago (2015-11-18 20:45:42 UTC) #3
ramant (doing other things)
chrome/browser/net/predictor.cc changes LGTM.
5 years, 1 month ago (2015-11-18 20:53:11 UTC) #4
Mr4D (OOO till 08-26)
browser/profiles lgtm
5 years, 1 month ago (2015-11-19 00:10:50 UTC) #5
Deprecated (see juliatuttle)
components/domain_reliability lgtm
5 years, 1 month ago (2015-11-19 00:20:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456123002/1
5 years, 1 month ago (2015-11-19 15:00:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/131294)
5 years, 1 month ago (2015-11-19 15:15:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456123002/1
5 years, 1 month ago (2015-11-19 15:17:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 16:13:21 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:14:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0476ccefa17a0849652b7e0b9af878e8d297b82
Cr-Commit-Position: refs/heads/master@{#360595}

Powered by Google App Engine
This is Rietveld 408576698