Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1456113002: Make has GrBatchAtlas::ID() inlineable (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make has GrBatchAtlas::ID() inlineable BUG=skia: Committed: https://skia.googlesource.com/skia/+/5df175ee71164dce97758564f308ab301bfe393a

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -194 lines) Patch
M src/gpu/GrBatchAtlas.h View 1 5 chunks +116 lines, -6 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 4 chunks +85 lines, -188 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
5 years, 1 month ago (2015-11-18 20:33:12 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1456113002/diff/1/src/gpu/GrBatchAtlas.h File src/gpu/GrBatchAtlas.h (right): https://codereview.chromium.org/1456113002/diff/1/src/gpu/GrBatchAtlas.h#newcode162 src/gpu/GrBatchAtlas.h:162: // To manage the lifetime of a plot, ...
5 years, 1 month ago (2015-11-18 20:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456113002/20001
5 years, 1 month ago (2015-11-18 21:19:53 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 21:37:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5df175ee71164dce97758564f308ab301bfe393a

Powered by Google App Engine
This is Rietveld 408576698