Source/core/rendering/RenderTableSection.h - Issue 145603002: Eliminate large chunks of nearly duplicated code for table-row-group border calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 145603002: Eliminate large chunks of nearly duplicated code for table-row-group border calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTableSection.h

diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h

index 07866bd1afc2618122697340f572807282c0c27d..676e5669dc2bb68b39b37baea7d26e7913d56c86 100644

--- a/Source/core/rendering/RenderTableSection.h

+++ b/Source/core/rendering/RenderTableSection.h

@@ -174,10 +174,8 @@ public:

void appendColumn(unsigned pos);

void splitColumn(unsigned pos, unsigned first);

- int calcOuterBorderBefore() const;

- int calcOuterBorderAfter() const;

- int calcOuterBorderStart() const;

- int calcOuterBorderEnd() const;

+ enum BorderSide { BorderBefore, BorderAfter, BorderStart, BorderEnd };

+ int calcOuterBorder(BorderSide) const;

void recalcOuterBorder();

int outerBorderBefore() const { return m_outerBorderBefore; }

« no previous file with comments | « no previous file | Source/core/rendering/RenderTableSection.cpp » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')