Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1456003003: Simplify dispatch in optimizing compile stubs. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify dispatch in optimizing compile stubs. This is to re-establish a single choke point for lazy compile stubs in preparation for CallRuntimePassFunction being changed soon. R=bmeurer@chromium.org Committed: https://crrev.com/c0bf04b119c2968955eb69d6650e67068128629f Cr-Commit-Position: refs/heads/master@{#32095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -159 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +9 lines, -8 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +21 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Because duplicated code is best code. Benedikt: PTAL. Yang: FYI.
5 years, 1 month ago (2015-11-18 16:29:59 UTC) #1
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-11-18 19:27:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456003003/1
5 years, 1 month ago (2015-11-18 19:32:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 19:34:07 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:34:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0bf04b119c2968955eb69d6650e67068128629f
Cr-Commit-Position: refs/heads/master@{#32095}

Powered by Google App Engine
This is Rietveld 408576698