Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1455953002: [turbofan] Fix deoptimization from array literal spread. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deoptimization from array literal spread. This fixes the array literal expression stack tracking in the presence of spread expressions. Deoptimization within a spread expression was borked. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-deopt-in-array-literal-spread Committed: https://crrev.com/279f2aad938ebfbd94e7074f33597204191c4c45 Cr-Commit-Position: refs/heads/master@{#32079}

Patch Set 1 #

Patch Set 2 : Skip ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-deopt-in-array-literal-spread.js View 1 chunk +4 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-osr-in-literal.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-18 10:49:33 UTC) #1
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-18 10:50:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455953002/20001
5 years, 1 month ago (2015-11-18 11:43:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 11:45:13 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 11:45:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/279f2aad938ebfbd94e7074f33597204191c4c45
Cr-Commit-Position: refs/heads/master@{#32079}

Powered by Google App Engine
This is Rietveld 408576698