third_party/WebKit/Source/platform/heap/Handle.h - Issue 1455943002: [Oilpan] Prepare full definition of classes before using Member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1455943002: [Oilpan] Prepare full definition of classes before using Member (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CORE_EXPORT Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/Filter.cpp ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/Handle.h

diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h

index 64e43fd71243011277fb2052e26dfe146148b0dc..1c723468434d49f130be1f9c04b6e6c655227fa8 100644

--- a/third_party/WebKit/Source/platform/heap/Handle.h

+++ b/third_party/WebKit/Source/platform/heap/Handle.h

@@ -771,7 +771,11 @@ public:

checkPointer();

}

- T* get() const { return m_raw; }

+ T* get() const

+ {

+ static_assert(IsFullyDefined<T>::value, "T is not fully defined.");

+ return m_raw;

+ }

void clear() { m_raw = nullptr; }

@@ -779,6 +783,8 @@ public:

protected:

void checkPointer()

{

+ static_assert(IsFullyDefined<T>::value, "T is not fully defined.");

#if ENABLE(ASSERT) && defined(ADDRESS_SANITIZER)

if (!m_raw)

return;