third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 1455943002: [Oilpan] Prepare full definition of classes before using Member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1455943002: [Oilpan] Prepare full definition of classes before using Member (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CORE_EXPORT Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 980f33aa210609a2dc9eb0c08ff41aa2e52a4cab..66ec3be9c8c5e5e46e3990fd46e2d5870dcdc411 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -234,7 +234,7 @@ public:

bool hasPendingActivity() const final;

#if ENABLE(WEB_AUDIO)

- AudioSourceProviderClient* audioSourceNode() { return m_audioSourceNode; }

+ AudioSourceProviderClient* audioSourceNode();

void setAudioSourceNode(AudioSourceProviderClient*);

AudioSourceProvider& audioSourceProvider() { return m_audioSourceProvider; }

@@ -574,11 +574,7 @@ private:

// When the audio format is known, Chromium calls setFormat().

class AudioClientImpl final : public GarbageCollectedFinalized<AudioClientImpl>, public WebAudioSourceProviderClient {

public:

- explicit AudioClientImpl(AudioSourceProviderClient* client)

- : m_client(client)

- {

- }

+ explicit AudioClientImpl(AudioSourceProviderClient*);

~AudioClientImpl() override { }

// WebAudioSourceProviderClient