include/v8config.h - Issue 145593003: v8config.h: set V8_CC_MSVC when building with clang-cl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8config.h

Issue 145593003: v8config.h: set V8_CC_MSVC when building with clang-cl (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Re-upload Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8config.h

diff --git a/include/v8config.h b/include/v8config.h

index 8661a0d0c79de33757785bce9bea04b9adab7c7f..0409e5bcd06635b766ff6a982b5cf632791de19d 100644

--- a/include/v8config.h

+++ b/include/v8config.h

@@ -234,6 +234,10 @@

# define V8_HAS_CXX11_FINAL (__has_feature(cxx_override_control))

# define V8_HAS_CXX11_OVERRIDE (__has_feature(cxx_override_control))

+# if defined(_MSC_VER)

Benedikt Meurer 2014/01/27 06:25:38 Please add a comment why this is necessary.

+# define V8_CC_MSVC 1

+# endif

#elif defined(__GNUC__)

# define V8_CC_GNU 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »