include/v8config.h - Issue 145593003: v8config.h: set V8_CC_MSVC when building with clang-cl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8config.h

Issue 145593003: v8config.h: set V8_CC_MSVC when building with clang-cl (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Introduce V8_LIBC_MSVCRT Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8config.h

diff --git a/include/v8config.h b/include/v8config.h

index 8661a0d0c79de33757785bce9bea04b9adab7c7f..0d99e56586083fab337e4cea01205c86ccb63cf2 100644

--- a/include/v8config.h

+++ b/include/v8config.h

@@ -139,6 +139,7 @@

// -----------------------------------------------------------------------------

// C library detection

+// V8_LIBC_MSVCRT - MSVC libc

// V8_LIBC_BIONIC - Bionic libc

// V8_LIBC_BSD - BSD libc derivate

// V8_LIBC_GLIBC - GNU C library

@@ -150,7 +151,9 @@

// ...

// #endif

-#if defined(__BIONIC__)

+#if defined (_MSC_VER)

+# define V8_LIBC_MSVCRT 1

+#elif defined(__BIONIC__)

# define V8_LIBC_BIONIC 1

# define V8_LIBC_BSD 1

#elif defined(__UCLIBC__)

« no previous file with comments | « no previous file | src/cpu.cc » ('j') | no next file with comments »