Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: src/compiler/operator.h

Issue 1455913003: [turbofan] Fix CFI failures with Operator1 class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Better solution. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-operator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/operator.h
diff --git a/src/compiler/operator.h b/src/compiler/operator.h
index eba430f927c525e777213c4a762a587fd94cf1f2..026ecba1d44f47eb1a189f9cc7f8114fb5694a1f 100644
--- a/src/compiler/operator.h
+++ b/src/compiler/operator.h
@@ -136,10 +136,19 @@ DEFINE_OPERATORS_FOR_FLAGS(Operator::Properties)
std::ostream& operator<<(std::ostream& os, const Operator& op);
+// Default equality function for below Operator1<*> class.
+template <typename T>
+struct OpEqualTo : public std::equal_to<T> {};
+
+
+// Default hashing function for below Operator1<*> class.
+template <typename T>
+struct OpHash : public base::hash<T> {};
+
+
// A templatized implementation of Operator that has one static parameter of
-// type {T}.
-template <typename T, typename Pred = std::equal_to<T>,
- typename Hash = base::hash<T>>
+// type {T} with the proper default equality and hashing functions.
+template <typename T, typename Pred = OpEqualTo<T>, typename Hash = OpHash<T>>
class Operator1 : public Operator {
public:
Operator1(Opcode opcode, Properties properties, const char* mnemonic,
@@ -183,46 +192,38 @@ class Operator1 : public Operator {
// Helper to extract parameters from Operator1<*> operator.
template <typename T>
inline T const& OpParameter(const Operator* op) {
- return reinterpret_cast<const Operator1<T>*>(op)->parameter();
+ return reinterpret_cast<const Operator1<T, OpEqualTo<T>, OpHash<T>>*>(op)
+ ->parameter();
}
+
// NOTE: We have to be careful to use the right equal/hash functions below, for
// float/double we always use the ones operating on the bit level, for Handle<>
// we always use the ones operating on the location level.
template <>
-inline float const& OpParameter(const Operator* op) {
- return reinterpret_cast<const Operator1<float, base::bit_equal_to<float>,
- base::bit_hash<float>>*>(op)
- ->parameter();
-}
+struct OpEqualTo<float> : public base::bit_equal_to<float> {};
+template <>
+struct OpHash<float> : public base::bit_hash<float> {};
template <>
-inline double const& OpParameter(const Operator* op) {
- return reinterpret_cast<const Operator1<double, base::bit_equal_to<double>,
- base::bit_hash<double>>*>(op)
- ->parameter();
-}
+struct OpEqualTo<double> : public base::bit_equal_to<double> {};
+template <>
+struct OpHash<double> : public base::bit_hash<double> {};
template <>
-inline Handle<HeapObject> const& OpParameter(const Operator* op) {
- return reinterpret_cast<
- const Operator1<Handle<HeapObject>, Handle<HeapObject>::equal_to,
- Handle<HeapObject>::hash>*>(op)->parameter();
-}
+struct OpEqualTo<Handle<HeapObject>> : public Handle<HeapObject>::equal_to {};
+template <>
+struct OpHash<Handle<HeapObject>> : public Handle<HeapObject>::hash {};
template <>
-inline Handle<String> const& OpParameter(const Operator* op) {
- return reinterpret_cast<const Operator1<
- Handle<String>, Handle<String>::equal_to, Handle<String>::hash>*>(op)
- ->parameter();
-}
+struct OpEqualTo<Handle<String>> : public Handle<String>::equal_to {};
+template <>
+struct OpHash<Handle<String>> : public Handle<String>::hash {};
template <>
-inline Handle<ScopeInfo> const& OpParameter(const Operator* op) {
- return reinterpret_cast<
- const Operator1<Handle<ScopeInfo>, Handle<ScopeInfo>::equal_to,
- Handle<ScopeInfo>::hash>*>(op)->parameter();
-}
+struct OpEqualTo<Handle<ScopeInfo>> : public Handle<ScopeInfo>::equal_to {};
+template <>
+struct OpHash<Handle<ScopeInfo>> : public Handle<ScopeInfo>::hash {};
} // namespace compiler
} // namespace internal
« no previous file with comments | « src/compiler/js-operator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698