Issue 1455883004: [crankshaft] only compile string index access with element key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1455883004: [crankshaft] only compile string index access with element key. (Closed)

Created:
5 years, 1 month ago by Yang

Modified:
5 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[crankshaft] only compile string index access with element key. R=bmeurer@chromium.org BUG=chromium:554831 LOG=N Committed: https://crrev.com/5bcddae76f2428fbc3a7d083687f3280c3027b0f Cr-Commit-Position: refs/heads/master@{#32084}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/crankshaft/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-554831.js	View		1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455883004/1

5 years, 1 month ago (2015-11-18 12:37:19 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-18 13:53:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5bcddae76f2428fbc3a7d083687f3280c3027b0f
Cr-Commit-Position: refs/heads/master@{#32084}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages